nastra commented on a change in pull request #2664:
URL: https://github.com/apache/iceberg/pull/2664#discussion_r649388083



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkCatalog.java
##########
@@ -97,6 +97,8 @@ protected Catalog buildIcebergCatalog(String name, 
CaseInsensitiveStringMap opti
     Configuration conf = SparkSession.active().sessionState().newHadoopConf();
     Map<String, String> optionsMap = new 
TreeMap<>(String.CASE_INSENSITIVE_ORDER);
     optionsMap.putAll(options);
+    optionsMap.put("app-id", 
SparkSession.active().sparkContext().applicationId());
+    optionsMap.put("user", SparkSession.active().sparkContext().sparkUser());

Review comment:
       I was hesitant to move them to a central place initially, but we'll 
probably will need those at least for Flink as well, so let's move them to 
`CatalogProperties`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to