marton-bod commented on a change in pull request #2691:
URL: https://github.com/apache/iceberg/pull/2691#discussion_r649845894
##########
File path: core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java
##########
@@ -290,7 +292,9 @@ private void
checkForRedundantAddedPartitions(PartitionField field) {
ImmutableMap.Builder<Pair<Integer, String>, PartitionField> builder =
ImmutableMap.builder();
List<PartitionField> fields = spec.fields();
for (PartitionField field : fields) {
- builder.put(Pair.of(field.sourceId(), field.transform().toString()),
field);
+ if (!field.transform().isVoid()) {
Review comment:
Just a thought: would it make sense to just do `!(field.transform()
instanceof VoidTransform)` here? Then you wouldn't need the extra interface
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
