rdblue commented on a change in pull request #2660:
URL: https://github.com/apache/iceberg/pull/2660#discussion_r651335823



##########
File path: core/src/main/java/org/apache/iceberg/util/SnapshotUtil.java
##########
@@ -107,4 +122,16 @@ public static boolean ancestorOf(Table table, long 
snapshotId, long ancestorSnap
 
     return newFiles;
   }
+
+  public static Integer existingDataFiles(Snapshot snapshot) {

Review comment:
       I don't think this should return an `Integer`. There isn't a case that I 
can think of where the value should be null.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to