nastra opened a new pull request #2756:
URL: https://github.com/apache/iceberg/pull/2756
While working on some other code where I was debugging an issue that
resulted in failing checks in `TestHelpers`. Those failing checks were
essentially of the form `Should be XYZ` without actually knowing what the
actual value was, thus requiring to add some additional context to the failure
message.
For example, the check `Assert.assertTrue("Should be a long", actual
instanceof Long)` could fail either if `actual` is `null` or of a different
type. Yet one doesn't know and has to add some additional context to understand
what `actual`'s value is.
Therefore it seems better to move to AssertJ checks, where the actual value
will be reported.
Note that I didn't touch all the other `Assert.assertEquals` checks in order
to keep the change set to an absolute minimum but still improve the debugging
experience when a test fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
