sshkvar commented on a change in pull request #2757:
URL: https://github.com/apache/iceberg/pull/2757#discussion_r661502786
##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/Reader.java
##########
@@ -329,8 +335,10 @@ public boolean enableBatchRead() {
boolean batchReadsEnabled = batchReadsEnabled(allParquetFileScanTasks,
allOrcFileScanTasks);
+ boolean hasTimestampWithoutZone =
SparkUtil.hasTimestampWithoutZone(lazySchema());
+
this.readUsingBatch = batchReadsEnabled && hasNoDeleteFiles &&
(allOrcFileScanTasks ||
- (allParquetFileScanTasks && atLeastOneColumn && onlyPrimitives));
+ (allParquetFileScanTasks && atLeastOneColumn && onlyPrimitives
&& !hasTimestampWithoutZone));
Review comment:
This code was added by @bkahloon, but I agree that we don't need this
check.
I have removed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
