rdblue commented on a change in pull request #2591: URL: https://github.com/apache/iceberg/pull/2591#discussion_r664863221
########## File path: core/src/main/java/org/apache/iceberg/actions/RewriteFileGroup.java ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.actions; + +import java.util.Collections; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; +import org.apache.iceberg.DataFile; +import org.apache.iceberg.FileScanTask; +import org.apache.iceberg.StructLike; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * Container class representing a set of files to be rewritten by a RewriteAction and the new files which have been + * written by the action. + */ +public class RewriteFileGroup { + private final RewriteDataFiles.FileGroupInfo info; + private final List<FileScanTask> fileScanTasks; + private final int numInputFiles; + + private Set<DataFile> outputFiles = Collections.emptySet(); + private int numOutputFiles; + + public RewriteFileGroup(RewriteDataFiles.FileGroupInfo info, List<FileScanTask> fileScanTasks) { + this.info = info; + this.fileScanTasks = fileScanTasks; + this.numInputFiles = fileScanTasks.size(); + } + + public int numInputFiles() { + return numInputFiles; + } Review comment: Are all these methods needed? It seems like this may only need `info` and `asResult`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
