nastra commented on pull request #2797: URL: https://github.com/apache/iceberg/pull/2797#issuecomment-877219901
> @nastra just to double check, this doesn't change anything in terms of test order, log messages, etc it only enables us to use the new junit. Correct? There shouldn't be any real differences in terms of test execution or the like. As stated in the PR description, `junit-vintage-engine` is what's responsible for running JUnit 4 compatible tests, which uses **4.13**. One limitation that's worth mentioning is probably the limited support for JUnit4 native rules as stated [here](https://junit.org/junit5/docs/current/user-guide/#migrating-from-junit4-rule-support) but I don't think that this affects the Iceberg project as I haven't seen any custom Rules in the project. > What does mixed junit4 and junit5 look like? Can we have a module or class w/ annotations from both versions? Is there any danger in that? Would the recommendation be to use junit5 on new tests? I haven't really tried a mixed scenario of JUnit4 & JUnit5 within the same class and I would assume that one would rather fully write either JUnit4 or JUnit5 code within the same class. I would probably recommend writing JUnit5 style tests for new code, but it doesn't really matter, as people can still just write JUnit4 code as they were used to. Having people write JUnit5 tests for new stuff would probably only matter if the project at some point would like to migrate all existing JUnit4 tests to JUnit5, but I don't think that will happen in the near future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
