holdenk commented on a change in pull request #2761:
URL: https://github.com/apache/iceberg/pull/2761#discussion_r679363896
##########
File path: python/iceberg/api/expressions/inclusive_manifest_evaluator.py
##########
@@ -159,3 +159,7 @@ def in_(self, ref, lit):
def not_in(self, ref, lit):
return ROWS_MIGHT_MATCH
+
+ def starts_with(self, ref, lit):
+ # if it's all null then we can't match :)
+ return self.not_null(ref)
Review comment:
I don't have strong views here either, my only consideration with
changing it to `return ROWS_CANNOT_MATCH if self.not_null(ref) else
ROWS_MIGHT_MATCH` would be if we ever change this from wrapping
ROWS_CANNOT_MATCH/ROWS_MIGHT_MATCH true/false it would brake but we'd catch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
