findepi commented on a change in pull request #2891:
URL: https://github.com/apache/iceberg/pull/2891#discussion_r679690689
##########
File path: site/docs/spec.md
##########
@@ -267,7 +267,8 @@ A sort order is defined by an sort order id and a list of
sort fields. The order
Order id `0` is reserved for the unsorted order.
-Sorting floating-point numbers should produce the following behavior: `-NaN` <
`-Infinity` < `-value` < `-0` < `0` < `value` < `Infinity` < `NaN`. This aligns
with the implementation of Java floating-point types comparisons.
+Sorting floating-point numbers should produce the following behavior:
`-Infinity` < `-value` < `-0` < `0` < `value` < `Infinity` < `NaN`.
+The different `NaN` representation can be in an arbitrary order. This aligns
with the implementation of Java floating-point types comparisons.
Review comment:
"order" was supposed to refer to sorting from the previous sentence. can
i ask you for help on better wording?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
