openinx commented on a change in pull request #2886:
URL: https://github.com/apache/iceberg/pull/2886#discussion_r679745954
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -118,6 +117,7 @@ public static Builder forRowData(DataStream<RowData> input)
{
public static class Builder {
private DataStream<RowData> rowDataInput = null;
+ private SingleOutputStreamOperator<RowData> mappedRowDataInput = null;
Review comment:
I'd prefer not introducing another `DataStream<RowData>` named
`mappedRowDataInput` into this Builder, because that could easily confuse
people: which `DataStream` should I use to chain the following operators ?
Let's just keep the only one `rowDataInput` even if we've chained a
`MapFunction`, we could still add the `uid` and `name` lazily to the `Map`
operator ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
