nastra commented on pull request #2826: URL: https://github.com/apache/iceberg/pull/2826#issuecomment-891943246
> Looks good to me, If it is possible I would try to separate out the build changes from the format changes if possible. Like first doing a bump of baseline if we can do that without the gradle change then doing the gradle change. > > But I don't have strong feelings about that, and if all of our artifacts are the same before and after this Patch I think we are ok. I would recommend we double check the spark31 - spark tests to make sure their runtime class-paths are still correct. I tried to do that by creating 4 commits and keeping relevant things related to each other within a particular commit. I'm not sure doing the commits in reverse order is better here as I see those as logical steps: 1) Upgrade to Gradle 7 with related plugins that don't work otherwise 2) fix formatting or errorprone stuff separately due to newer versions in separate commits -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
