RussellSpitzer commented on a change in pull request #2936:
URL: https://github.com/apache/iceberg/pull/2936#discussion_r682956450
##########
File path: core/src/main/java/org/apache/iceberg/Partitioning.java
##########
@@ -177,4 +184,35 @@ public Void alwaysNull(int fieldId, String sourceName, int
sourceId) {
return null;
}
}
+
+ /**
+ * Builds a common partition type for all specs in a table.
Review comment:
Could we add some detail in here? Seems like we are building a Struct
which contains every field which has been part of a partitionspec in the past.
So I would probably just write "Builds a struct containing all columns which
have been ever been a part of a partition spec in this table"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
