RussellSpitzer commented on a change in pull request #2984:
URL: https://github.com/apache/iceberg/pull/2984#discussion_r689855103
##########
File path: core/src/main/java/org/apache/iceberg/Partitioning.java
##########
@@ -246,4 +246,45 @@ private static boolean
equivalentIgnoringNames(PartitionField field, PartitionFi
private static boolean compatibleTransforms(Transform<?, ?> t1, Transform<?,
?> t2) {
return t1.equals(t2) || t1.equals(Transforms.alwaysNull()) ||
t2.equals(Transforms.alwaysNull());
}
+
+ /**
+ * Adapts the provided partition data to match the table partition type
built using {@link #partitionType(Table)}.
+ *
+ * @param partitionType a table partition type that includes partition
fields from all specs
Review comment:
What is the behavior for when the partition does not contain a field
that is required to create the target partition type
Like if I add a column, and then partition on that column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
