jackye1995 commented on a change in pull request #2986:
URL: https://github.com/apache/iceberg/pull/2986#discussion_r690599016



##########
File path: site/docs/releases.md
##########
@@ -64,28 +64,36 @@ High-level features:
 
 * **Core**
   * Allow Iceberg schemas to specify one or more columns as row identifers 
[[\#2465](https://github.com/apache/iceberg/pull/2465)]. Note that this is a 
prerequisite for supporting upserts in Flink.
-  * Added JDBC [[\#1870](https://github.com/apache/iceberg/pull/1870)] and 
DynamoDB [[\#2688](https://github.com/apache/iceberg/pull/2688)] Iceberg 
catalog implementations.
+  * Added JDBC [[\#1870](https://github.com/apache/iceberg/pull/1870)] and 
DynamoDB [[\#2688](https://github.com/apache/iceberg/pull/2688)] catalog 
implementations.
   * Added predicate pushdown for partitions and files metadata tables 
[[\#2358](https://github.com/apache/iceberg/pull/2358), 
[\#2926](https://github.com/apache/iceberg/pull/2926)].
   * Added a new, more flexible compaction action for Spark that can support 
different strategies such as bin packing and sorting. 
[[\#2501](https://github.com/apache/iceberg/pull/2501), 
[\#2609](https://github.com/apache/iceberg/pull/2609)].
   * Added the ability to upgrade to v2 or create a v2 table using the table 
property format-version=2  
[[\#2887](https://github.com/apache/iceberg/pull/2887)].
+* **Flink**
+  * Added support for SQL primary keys 
[[\#2410](https://github.com/apache/iceberg/pull/2410)].
+* **Hive**
+  * Added the ability to set the catalog at the table level in the Hive 
Metastore. This makes it possible to write queries that reference tables from 
multiple catalogs [[\#2129](https://github.com/apache/iceberg/pull/2129)].
+  * Deprecated the configuration property `iceberg.mr.catalog` is now 
deprecated [[\#2565](https://github.com/apache/iceberg/pull/2565)].

Review comment:
       nit: 2 "deprecated". I think we should say "Configuring Iceberg catalog 
implementation in Hive using `iceberg.mr.catalog` is now deprecated"

##########
File path: site/docs/releases.md
##########
@@ -64,28 +64,36 @@ High-level features:
 
 * **Core**
   * Allow Iceberg schemas to specify one or more columns as row identifers 
[[\#2465](https://github.com/apache/iceberg/pull/2465)]. Note that this is a 
prerequisite for supporting upserts in Flink.
-  * Added JDBC [[\#1870](https://github.com/apache/iceberg/pull/1870)] and 
DynamoDB [[\#2688](https://github.com/apache/iceberg/pull/2688)] Iceberg 
catalog implementations.
+  * Added JDBC [[\#1870](https://github.com/apache/iceberg/pull/1870)] and 
DynamoDB [[\#2688](https://github.com/apache/iceberg/pull/2688)] catalog 
implementations.
   * Added predicate pushdown for partitions and files metadata tables 
[[\#2358](https://github.com/apache/iceberg/pull/2358), 
[\#2926](https://github.com/apache/iceberg/pull/2926)].
   * Added a new, more flexible compaction action for Spark that can support 
different strategies such as bin packing and sorting. 
[[\#2501](https://github.com/apache/iceberg/pull/2501), 
[\#2609](https://github.com/apache/iceberg/pull/2609)].
   * Added the ability to upgrade to v2 or create a v2 table using the table 
property format-version=2  
[[\#2887](https://github.com/apache/iceberg/pull/2887)].
+* **Flink**
+  * Added support for SQL primary keys 
[[\#2410](https://github.com/apache/iceberg/pull/2410)].
+* **Hive**
+  * Added the ability to set the catalog at the table level in the Hive 
Metastore. This makes it possible to write queries that reference tables from 
multiple catalogs [[\#2129](https://github.com/apache/iceberg/pull/2129)].
+  * Deprecated the configuration property `iceberg.mr.catalog` is now 
deprecated [[\#2565](https://github.com/apache/iceberg/pull/2565)].
+  * Enabled dropping HMS tables despite metadata problems 
[[\#2583](https://github.com/apache/iceberg/pull/2583)].
+  * Added table-level JVM lock on 
commits[[\#2547](https://github.com/apache/iceberg/pull/2547)].
+  * Use Hive's vectorized ORC reader 
[[\#2613](https://github.com/apache/iceberg/pull/2613)].
 * **Spark**
-  * [[\#2560](https://github.com/apache/iceberg/pull/2560)] added extensions 
DDL to set identifier fields.
-  * [[\#2365](https://github.com/apache/iceberg/pull/2365)] added support for 
`ALTER TABLE table CHANGE PARTITION FIELD transform TO transform` DDL.
-  * [[\#2660](https://github.com/apache/iceberg/pull/2660)] added support for 
micro-batch streaming reads for structured streaming in Spark3.
-  * [[\#2777](https://github.com/apache/iceberg/pull/2777)] improves the 
performance of importing a Hive table by not loading all partitions from Hive 
and instead pushing the partition filter to the Metastore.
-  * [[\#2193](https://github.com/apache/iceberg/pull/2193), 
[\#2206](https://github.com/apache/iceberg/pull/2206)] added support for UPDATE 
statements in Spark.
-* **Flink** now support SQL primary keys 
[[\#2410](https://github.com/apache/iceberg/pull/2410)].
+  * Added extensions DDL to set identifier fields 
[[\#2560](https://github.com/apache/iceberg/pull/2560)].
+  * Added support for `ALTER TABLE table CHANGE PARTITION FIELD transform TO 
transform` DDL [[\#2365](https://github.com/apache/iceberg/pull/2365)].

Review comment:
       `REPLACE PARTITION FIELD`, not `CHANGE PARTITION FIELD`

##########
File path: site/docs/releases.md
##########
@@ -64,28 +64,36 @@ High-level features:
 
 * **Core**
   * Allow Iceberg schemas to specify one or more columns as row identifers 
[[\#2465](https://github.com/apache/iceberg/pull/2465)]. Note that this is a 
prerequisite for supporting upserts in Flink.
-  * Added JDBC [[\#1870](https://github.com/apache/iceberg/pull/1870)] and 
DynamoDB [[\#2688](https://github.com/apache/iceberg/pull/2688)] Iceberg 
catalog implementations.
+  * Added JDBC [[\#1870](https://github.com/apache/iceberg/pull/1870)] and 
DynamoDB [[\#2688](https://github.com/apache/iceberg/pull/2688)] catalog 
implementations.
   * Added predicate pushdown for partitions and files metadata tables 
[[\#2358](https://github.com/apache/iceberg/pull/2358), 
[\#2926](https://github.com/apache/iceberg/pull/2926)].
   * Added a new, more flexible compaction action for Spark that can support 
different strategies such as bin packing and sorting. 
[[\#2501](https://github.com/apache/iceberg/pull/2501), 
[\#2609](https://github.com/apache/iceberg/pull/2609)].
   * Added the ability to upgrade to v2 or create a v2 table using the table 
property format-version=2  
[[\#2887](https://github.com/apache/iceberg/pull/2887)].
+* **Flink**
+  * Added support for SQL primary keys 
[[\#2410](https://github.com/apache/iceberg/pull/2410)].
+* **Hive**
+  * Added the ability to set the catalog at the table level in the Hive 
Metastore. This makes it possible to write queries that reference tables from 
multiple catalogs [[\#2129](https://github.com/apache/iceberg/pull/2129)].
+  * Deprecated the configuration property `iceberg.mr.catalog` is now 
deprecated [[\#2565](https://github.com/apache/iceberg/pull/2565)].
+  * Enabled dropping HMS tables despite metadata problems 
[[\#2583](https://github.com/apache/iceberg/pull/2583)].
+  * Added table-level JVM lock on 
commits[[\#2547](https://github.com/apache/iceberg/pull/2547)].
+  * Use Hive's vectorized ORC reader 
[[\#2613](https://github.com/apache/iceberg/pull/2613)].
 * **Spark**
-  * [[\#2560](https://github.com/apache/iceberg/pull/2560)] added extensions 
DDL to set identifier fields.
-  * [[\#2365](https://github.com/apache/iceberg/pull/2365)] added support for 
`ALTER TABLE table CHANGE PARTITION FIELD transform TO transform` DDL.
-  * [[\#2660](https://github.com/apache/iceberg/pull/2660)] added support for 
micro-batch streaming reads for structured streaming in Spark3.
-  * [[\#2777](https://github.com/apache/iceberg/pull/2777)] improves the 
performance of importing a Hive table by not loading all partitions from Hive 
and instead pushing the partition filter to the Metastore.
-  * [[\#2193](https://github.com/apache/iceberg/pull/2193), 
[\#2206](https://github.com/apache/iceberg/pull/2206)] added support for UPDATE 
statements in Spark.
-* **Flink** now support SQL primary keys 
[[\#2410](https://github.com/apache/iceberg/pull/2410)].
+  * Added extensions DDL to set identifier fields 
[[\#2560](https://github.com/apache/iceberg/pull/2560)].
+  * Added support for `ALTER TABLE table CHANGE PARTITION FIELD transform TO 
transform` DDL [[\#2365](https://github.com/apache/iceberg/pull/2365)].

Review comment:
       And I don't think we need the full SQL sentence, just `ALTER TABLE 
REPLACE PARTITION FIELD` should be good.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to