rdblue commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r696070195
##########
File path: baseline.gradle
##########
@@ -36,7 +36,7 @@ subprojects {
apply plugin: 'com.palantir.baseline-checkstyle'
apply plugin: 'com.palantir.baseline-error-prone'
}
- apply plugin: 'com.palantir.baseline-scalastyle'
+ apply plugin: 'com.github.alisiikh.scalastyle'
Review comment:
We can use third party plugins like this. While I don't see a license
for it, there is no reason to think that using it is prohibited because it is
published through the [Gradle plugin
repository](https://plugins.gradle.org/plugin/com.github.alisiikh.scalastyle).
The main concern we have with licensing is redistributing code. That is,
when you download our release tarball you also get a copy of some software, or
when you download a Jar from maven central you get a compiled copy. That
redistribution makes the artifact that is downloaded a derivative work.
This is different because we simply reference something in config and
whoever is using that config downloads and uses it. We are basically telling a
user how to build but not distributing the plugin, and the user downloads the
plugin when building this project. In that case, the license is between the
user downloading and running the plugin and the plugin author. That's why we
have a `gradlew` script that downloads gradle when building and we don't check
the gradle wrapper Jar into our source repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
