rdblue commented on a change in pull request #2925:
URL: https://github.com/apache/iceberg/pull/2925#discussion_r698068508
##########
File path: core/src/main/java/org/apache/iceberg/MergingSnapshotProducer.java
##########
@@ -247,11 +247,39 @@ private ManifestFile copyManifest(ManifestFile manifest) {
*
* @param base table metadata to validate
* @param startingSnapshotId id of the snapshot current at the start of the
operation
- * @param conflictDetectionFilter an expression used to find new conflicting
data files
+ * @param conflictDetectionFilter a data expression used to find new
conflicting data files
+ * @param caseSensitive whether expression evaluation should be case
sensitive
+ */
+ protected void validateAddedFilesWithDataFilter(TableMetadata base, Long
startingSnapshotId,
+ Expression
conflictDetectionFilter, boolean caseSensitive) {
+ validateAddedDataFiles(base, startingSnapshotId, conflictDetectionFilter,
Expressions.alwaysTrue(), caseSensitive);
+ }
+
+ /**
+ * Validates that no files matching a filter have been added to the table
since a starting snapshot.
+ *
+ * @param base table metadata to validate
+ * @param startingSnapshotId id of the snapshot current at the start of the
operation
+ * @param conflictDetectionFilter a partition expression used to find new
conflicting data files
+ * @param caseSensitive whether expression evaluation should be case
sensitive
+ */
+ protected void validateAddedFilesWithPartFilter(TableMetadata base, Long
startingSnapshotId,
Review comment:
Rather than splitting the expression, I think you can write an
alternative method that checks a `PartitionSet`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
