yyanyy commented on a change in pull request #3047:
URL: https://github.com/apache/iceberg/pull/3047#discussion_r701522932
##########
File path: core/src/main/java/org/apache/iceberg/CatalogUtil.java
##########
@@ -186,7 +186,7 @@ public static Catalog loadCatalog(
String.format("Cannot initialize Catalog, %s does not implement
Catalog.", impl), e);
}
- if (catalog instanceof Configurable) {
+ if (hadoopConf != null && catalog instanceof Configurable) {
Review comment:
I wonder if we can create a separate method for the same here but
without `Configuration`/`Configurable` as a parameter referenced anywhere, so
that we can create GlueCatalog without referring to any class within the hadoop
library at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
