wypoon commented on a change in pull request #1508:
URL: https://github.com/apache/iceberg/pull/1508#discussion_r702207560



##########
File path: 
spark3/src/main/java/org/apache/iceberg/spark/source/SparkBatchQueryScan.java
##########
@@ -79,6 +80,17 @@
     this.splitOpenFileCost = Spark3Util.propertyAsLong(options, 
SparkReadOptions.FILE_OPEN_COST, null);
   }
 
+  @Override
+  protected Schema snapshotSchema() {

Review comment:
       After working through how Spark constructs a `SparkBatchQueryScan`, I 
realize that you're right and that this method is not needed in 
`SparkBatchScan`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to