kbendick commented on a change in pull request #3069:
URL: https://github.com/apache/iceberg/pull/3069#discussion_r712770472
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -95,11 +101,18 @@ public OverwriteFiles caseSensitive(boolean
isCaseSensitive) {
@Override
public OverwriteFiles validateNoConflictingAppends(Expression
newConflictDetectionFilter) {
Preconditions.checkArgument(newConflictDetectionFilter != null, "Conflict
detection filter cannot be null");
Review comment:
Nit: Should this be `Append conflict detection filter cannot be null`
now that we have both appendConflictDetectionFilter and
delteConflictDectionFilter?
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -95,11 +101,18 @@ public OverwriteFiles caseSensitive(boolean
isCaseSensitive) {
@Override
public OverwriteFiles validateNoConflictingAppends(Expression
newConflictDetectionFilter) {
Preconditions.checkArgument(newConflictDetectionFilter != null, "Conflict
detection filter cannot be null");
- this.conflictDetectionFilter = newConflictDetectionFilter;
+ this.appendConflictDetectionFilter = newConflictDetectionFilter;
failMissingDeletePaths();
Review comment:
Question: Does this call to `failMissingDeletePaths()` still belong here
or should it be moved to the `validateNoConflictingDeleteFiles` call?
##########
File path: core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java
##########
@@ -95,11 +101,18 @@ public OverwriteFiles caseSensitive(boolean
isCaseSensitive) {
@Override
public OverwriteFiles validateNoConflictingAppends(Expression
newConflictDetectionFilter) {
Preconditions.checkArgument(newConflictDetectionFilter != null, "Conflict
detection filter cannot be null");
- this.conflictDetectionFilter = newConflictDetectionFilter;
+ this.appendConflictDetectionFilter = newConflictDetectionFilter;
failMissingDeletePaths();
return this;
}
+ @Override
+ public OverwriteFiles validateNoConflictingDeleteFiles(Expression
newConflictDetectionFilter) {
+ Preconditions.checkArgument(newConflictDetectionFilter != null, "Conflict
detection filter cannot be null");
Review comment:
Nit: Same comment about saying "Delete conflict detection filter cannot
be null` instead of leaving it unqualified and ambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
