kbendick commented on a change in pull request #3162:
URL: https://github.com/apache/iceberg/pull/3162#discussion_r713318349



##########
File path: site/docs/hive.md
##########
@@ -98,8 +98,8 @@ To globally register different catalogs, set the following 
Hadoop configurations
 
 | Config Key                                    | Description                  
                          |
 | --------------------------------------------- | 
------------------------------------------------------ |
-| iceberg.catalog.<catalog_name\>.type          | type of catalog: `hive` or 
`hadoop`                    |
-| iceberg.catalog.<catalog_name\>.catalog-impl  | catalog implementation, must 
not be null if type is null |
+| iceberg.catalog.<catalog_name\>.type          | type of catalog: `hive`, 
`hadoop` or empty if `catalog-impl` will be set.                  |

Review comment:
       Non-blocking notes:
   1) I agree that this can mostly be rolled back. I would say that `type` 
could be "hive or hadoop, or left unset if using a custom catalog".
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to