kbendick commented on pull request #3284: URL: https://github.com/apache/iceberg/pull/3284#issuecomment-942606758
> Looks good to me, only style thing is I am not sure if we need the example here as it gets a bit wordy (and might be a bit too specific to a spark-operation, for a generic spec) I thought that too. One thing that exists is number marks that drop to a sentence with further detail, where necessary. Like `[1]`. Here's an example: https://github.com/apache/iceberg/blob/86350db9507d6b0d19643beae25de0a758b6d3cb/site/docs/spec.md#L397-L403 However, I agree this one reads very particular to this case. My desire was to indicate that `-1` shouldn't be common, under normal situations. Though I'm not sure how true that is or if it matters. Will update to be more generic for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
