samredai edited a comment on issue #3217: URL: https://github.com/apache/iceberg/issues/3217#issuecomment-952150647
@jun-he @nssalian does "expressions" feel a bit broad? What are your thoughts on breaking this down into smaller chunks? From what I can tell, I think implementing expressions relies on the following (roughly in this order): - Literals - Operations - Terms - Boolean Expressions - Predicates (bounded and unbounded) - Binders - Expression Visitors Maybe each of this could be a separate issue + PR? The more incremental PRs would be easier to review as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
