stevenzwu commented on a change in pull request #2305:
URL: https://github.com/apache/iceberg/pull/2305#discussion_r739371220
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java
##########
@@ -40,4 +40,10 @@ private FlinkConfigOptions() {
.intType()
.defaultValue(100)
.withDescription("Sets max infer parallelism for source operator.");
+
+ public static final ConfigOption<Integer>
SOURCE_READER_FETCH_RECORD_BATCH_SIZE = ConfigOptions
+ .key("source.iceberg.reader.fetch-record-batch-size")
Review comment:
I didn't use `table.exec`, as this config isn't about table/SQL
execution behavior. This is the Iceberg source behavior (DataStream API or SQL).
I checked the two FLIP-27 source impls (Kafka and file) in Flink repo.
- Kafka source option doesn't contain any prefix, e.g.
"partition.discovery.interval.ms"
- file source does contain a prefix. e.g. "source.file.records.fetch-size"
This is following the file source convention.
@openinx any suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
