kbendick commented on a change in pull request #3420:
URL: https://github.com/apache/iceberg/pull/3420#discussion_r740482984
##########
File path: versions.props
##########
@@ -16,6 +16,7 @@ com.google.guava:guava = 28.0-jre
com.github.ben-manes.caffeine:caffeine = 2.8.4
org.apache.arrow:arrow-vector = 5.0.0
org.apache.arrow:arrow-memory-netty = 5.0.0
+io.netty:netty-buffer = 4.1.63.Final
Review comment:
+1 to moving the actual version over to this file instead of inline.
Question: Is there anyway to just enforce that it uses the version from
`iceberg-arrow` without including this? I worry about having to keep track of
such an important dependency.
##########
File path: build.gradle
##########
@@ -489,8 +489,11 @@ project(':iceberg-arrow') {
implementation("org.apache.arrow:arrow-memory-netty") {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
exclude group: 'io.netty', module: 'netty-common'
+ exclude group: 'io.netty', module: 'netty-buffer'
}
+ runtimeOnly("io.netty:netty-buffer")
Review comment:
Can we somehow tell it to pull from `arrow-memory-netty`, so that if
`arrow-memory-netty`'s version changes from bumping arrow deps, it will be
grabbed. Might be a non-goal though.
##########
File path: build.gradle
##########
@@ -489,8 +489,11 @@ project(':iceberg-arrow') {
implementation("org.apache.arrow:arrow-memory-netty") {
exclude group: 'com.google.code.findbugs', module: 'jsr305'
exclude group: 'io.netty', module: 'netty-common'
+ exclude group: 'io.netty', module: 'netty-buffer'
}
+ runtimeOnly("io.netty:netty-buffer")
Review comment:
Sorry for the confusion @flyrain. You answered my question via the
comment on the `versions.props` file. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
