rdblue commented on a change in pull request #3186:
URL: https://github.com/apache/iceberg/pull/3186#discussion_r741526482
##########
File path:
spark/v2.4/spark/src/test/java/org/apache/iceberg/spark/source/TestPartitionValues.java
##########
@@ -402,14 +402,13 @@ public void testPartitionedByNestedString() throws
Exception {
// input data frame
StructField[] structFields = {
- new StructField("struct",
- DataTypes.createStructType(
- new StructField[] {
- new StructField("string", DataTypes.StringType, false,
Metadata.empty())
- }
- ),
- false, Metadata.empty()
- )
+ new StructField("col1",
+ DataTypes.createStructType(
+ new StructField[] {
+ new StructField("f1", DataTypes.StringType, false,
Metadata.empty())
+ }
+ ), false, Metadata.empty()
+ )
Review comment:
Nearly all of the changes in this file are to formatting or names. Can
you remove any changes that are not strictly necessary for what you're trying
to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
