aokolnychyi commented on a change in pull request #3287:
URL: https://github.com/apache/iceberg/pull/3287#discussion_r743058702
##########
File path:
spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
##########
@@ -187,4 +202,45 @@ protected void withTableProperties(Map<String, String>
props, Action action) {
restoreProperties.commit();
}
}
+
+ protected void writePosDeletes(CharSequence path, long numRows, double
percentage) throws IOException {
+ OutputFileFactory fileFactory = newFileFactory();
+ SparkFileWriterFactory writerFactory =
SparkFileWriterFactory.builderFor(table())
+ .dataFileFormat(fileFormat())
Review comment:
Iceberg uses 4 spaces for continued indentation, not 8.
##########
File path:
spark/v3.2/spark/src/jmh/java/org/apache/iceberg/spark/source/IcebergSourceBenchmark.java
##########
@@ -187,4 +202,45 @@ protected void withTableProperties(Map<String, String>
props, Action action) {
restoreProperties.commit();
}
}
+
+ protected void writePosDeletes(CharSequence path, long numRows, double
percentage) throws IOException {
+ OutputFileFactory fileFactory = newFileFactory();
+ SparkFileWriterFactory writerFactory =
SparkFileWriterFactory.builderFor(table())
+ .dataFileFormat(fileFormat())
+ .build();
+
+ ClusteredPositionDeleteWriter<InternalRow> writer = new
ClusteredPositionDeleteWriter<>(
+ writerFactory, fileFactory, table().io(),
Review comment:
Here too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
