rdblue commented on a change in pull request #3456:
URL: https://github.com/apache/iceberg/pull/3456#discussion_r743779393



##########
File path: 
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/source/TestSparkMetadataColumns.java
##########
@@ -169,6 +170,35 @@ public void 
testPartitionMetadataColumnWithUnknownTransforms() {
         () -> sql("SELECT _partition FROM %s", TABLE_NAME));
   }
 
+  @Test
+  public void testConflictingColumns() {
+    table.updateSchema()
+        .addColumn(MetadataColumns.SPEC_ID.name(), Types.IntegerType.get())
+        .addColumn(MetadataColumns.FILE_PATH.name(), Types.StringType.get())
+        .commit();

Review comment:
       Maybe. I would like to avoid not allowing these names, but you're right 
that it would catch the problem earlier.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to