harshm-dev commented on pull request #3326: URL: https://github.com/apache/iceberg/pull/3326#issuecomment-961686675
- [@rymurr ] type and catalog-type kinda mean the same thing ... I wonder if we could deprecate one of them : I agree, that we should align the conf properties, make it `catalog-type` consistently. However, I would scope changing the conf property names as a separate track. - [@jackye1995 ] by enabling catalog type, we are forcing everyone to register the catalog as a type which is just more work without too much benefit compared to using impl for all new catalogs, and only keep type for backwards compatibility. There will always be private catalog implementations that you cannot express as an open source type and has to be loaded using impl anyway. Sorry I wasn't a part of previous discussion. The issue/change in not to use `type` in a forceful way, and does not remove the support for `catalog-impl`. I interpret these conf as follows -`catalog-impl` for custom catalog implementations, `type` for catalog implementations provided OOB by Iceberg. If we're using this method for few known types (hive/hadoop), why not do it for all the known types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
