rdblue commented on a change in pull request #3454:
URL: https://github.com/apache/iceberg/pull/3454#discussion_r744316266
##########
File path:
core/src/test/java/org/apache/iceberg/actions/TestBinPackStrategy.java
##########
@@ -150,6 +167,23 @@ public void testGroupingMinInputFilesValid() {
ImmutableList.of(testFiles), grouped);
}
+ @Test
+ public void testGroupingWithDeletes() {
+ RewriteStrategy strategy = defaultBinPack().options(ImmutableMap.of(
+ BinPackStrategy.MIN_INPUT_FILES, Integer.toString(5),
+ BinPackStrategy.MAX_FILE_SIZE_BYTES, Long.toString(550 * MB),
+ BinPackStrategy.MIN_FILE_SIZE_BYTES, Long.toString(490 * MB),
+ BinPackStrategy.MIN_DELETES_PER_FILE, Integer.toString(2)
Review comment:
@kbendick, can you check our checkstyle config? It looks like lines that
have incorrect indentation are getting through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
