nastra commented on a change in pull request #3543:
URL: https://github.com/apache/iceberg/pull/3543#discussion_r749212037
##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -30,6 +30,14 @@ private CatalogProperties() {
public static final String FILE_IO_IMPL = "io-impl";
public static final String WAREHOUSE_LOCATION = "warehouse";
+ public static final String TABLE_CACHE_ENABLED = "cache-enabled";
+ public static final boolean TABLE_CACHE_ENABLED_DEFAULT = true;
+ public static final String TABLE_CACHE_EXPIRATION_ENABLED =
"cache.expiration-enabled";
+ // Keep as false to maintain backwards compatability. Eventually consider
making true the default.
+ public static final boolean TABLE_CACHE_EXPIRATION_ENABLED_DEFAULT = false;
+ public static final String TABLE_CACHE_EXPIRATION_INTERVAL_MS =
"cache.expiration-interval-ms";
+ public static final long TABLE_CACHE_EXPIRATION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(15);
Review comment:
personally I think 15 mins is a very very long time. Intuitively I would
have assumed something around < 2 minutes as the default value. So even though
users can configure this as they like, I think that we should have
good/reasonable default values, but maybe there's a particular reason why we
think 15 mins is a good default?
##########
File path: core/src/main/java/org/apache/iceberg/CatalogProperties.java
##########
@@ -30,6 +30,14 @@ private CatalogProperties() {
public static final String FILE_IO_IMPL = "io-impl";
public static final String WAREHOUSE_LOCATION = "warehouse";
+ public static final String TABLE_CACHE_ENABLED = "cache-enabled";
+ public static final boolean TABLE_CACHE_ENABLED_DEFAULT = true;
+ public static final String TABLE_CACHE_EXPIRATION_ENABLED =
"cache.expiration-enabled";
+ // Keep as false to maintain backwards compatability. Eventually consider
making true the default.
+ public static final boolean TABLE_CACHE_EXPIRATION_ENABLED_DEFAULT = false;
+ public static final String TABLE_CACHE_EXPIRATION_INTERVAL_MS =
"cache.expiration-interval-ms";
+ public static final long TABLE_CACHE_EXPIRATION_INTERVAL_MS_DEFAULT =
TimeUnit.MINUTES.toMillis(15);
Review comment:
I guess if we remove `cache.expiration-enabled` and only use
`cache.expiration-interval-ms` I believe it could still make sense to have a
good default that is maybe > 0 but <= 2 mins. wdyt?
##########
File path: core/src/test/java/org/apache/iceberg/CachingCatalogTestHelper.java
##########
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import com.github.benmanes.caffeine.cache.Ticker;
+import java.time.Duration;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Locale;
+import java.util.Optional;
+import java.util.stream.Collectors;
+import org.apache.iceberg.catalog.Catalog;
+import org.apache.iceberg.catalog.TableIdentifier;
+import org.junit.Assert;
+
+/**
+ * Utility class for accessing package-private VisibleForTesting annotated
methods
+ * outside the org.apache.iceberg package.
+ */
+public class CachingCatalogTestHelper {
+
+ // TODO - Consider making this a delegator?
+ private CachingCatalogTestHelper() {
Review comment:
I would be in favor of removing `CachingCatalogTestHelper` and inline
the assertion checks within the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
