aokolnychyi commented on a change in pull request #3533:
URL: https://github.com/apache/iceberg/pull/3533#discussion_r749644011
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -448,6 +469,14 @@ public String toString() {
@Override
public void setBatchSize(int batchSize) {
+ this.batchSize = (batchSize == 0) ? DEFAULT_BATCH_SIZE : batchSize;
+ }
+
+ @Override
+ public void close() {
Review comment:
I matched the logic of the main reader where we have this:
```
@Override
public void close() {
if (vec != null) {
vec.close();
}
}
```
Looks like we are closing `FieldVector` for regular reads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
