izchen commented on a change in pull request #3460:
URL: https://github.com/apache/iceberg/pull/3460#discussion_r750613710
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/SparkTestBase.java
##########
@@ -157,7 +158,11 @@ private void assertEquals(String context, Object[]
expectedRow, Object[] actualR
Object actualValue = actualRow[col];
if (expectedValue != null && expectedValue.getClass().isArray()) {
String newContext = String.format("%s (nested col %d)", context, col +
1);
- assertEquals(newContext, (Object[]) expectedValue, (Object[])
actualValue);
+ if (expectedValue.getClass().getComponentType().isPrimitive()) {
+ new ExactComparisonCriteria().arrayEquals(newContext, expectedValue,
actualValue);
+ } else {
+ assertEquals(newContext, (Object[]) expectedValue, (Object[])
actualValue);
+ }
Review comment:
Thanks for your review, I have modified the code
##########
File path:
spark/v3.2/spark/src/test/java/org/apache/iceberg/spark/sql/TestSelect.java
##########
@@ -49,8 +49,8 @@ public TestSelect(String catalogName, String implementation,
Map<String, String>
@Before
public void createTables() {
- sql("CREATE TABLE %s (id bigint, data string, float float) USING iceberg",
tableName);
- sql("INSERT INTO %s VALUES (1, 'a', 1.0), (2, 'b', 2.0), (3, 'c',
float('NaN'))", tableName);
+ sql("CREATE TABLE %s (id bigint, data string, float float, binary binary)
USING iceberg", tableName);
+ sql("INSERT INTO %s VALUES (1, 'a', 1.0, X''), (2, 'b', 2.0, X'11'), (3,
'c', float('NaN'), X'1111')", tableName);
Review comment:
Thanks for your review, I have modified the code
##########
File path: api/src/main/java/org/apache/iceberg/util/ByteBuffers.java
##########
@@ -58,6 +59,11 @@ public static ByteBuffer copy(ByteBuffer buffer) {
return ByteBuffer.wrap(copyArray);
}
+ public static String encodeHexString(ByteBuffer buffer) {
+ byte[] bytes = toByteArray(buffer.duplicate());
Review comment:
Thanks for your review, I have modified the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
