jackye1995 commented on pull request #3270: URL: https://github.com/apache/iceberg/pull/3270#issuecomment-987536501
Trying to remember why the code was bundled in that way, it's in #1887. A shot summary of the approach used there was that: 1. use 1MB as a threshold, if the total size of the vendor's runtime module is less than 1MB, just include it 2. otherwise, we can include the iceberg integration code, but the vendor dependency is marked as provided and not bundled in the runtime jar. But I think what @openinx suggests also works, and it's a clean user experience. The reason we did not do that for the AWS module was that people usually have their preferred AWS SDK version that is used across their environment and upgraded together, so we don't want people to be bundled to an exact AWS SDK version that we offer. For example, AWS EMR maintains its own AWS SDK version and it's already in the java classpath, so user actually don't need to specify all those additional AWS SDK dependencies anyway, specifying it would potentially cause issue because of 2 SDK versions coexist. I don't know if this's also a concern for Aliyun. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
