RussellSpitzer commented on a change in pull request #3757:
URL: https://github.com/apache/iceberg/pull/3757#discussion_r771752595
##########
File path:
spark/v3.2/spark/src/main/scala/org/apache/spark/sql/execution/datasources/SparkExpressionConverter.scala
##########
@@ -30,4 +34,18 @@ object SparkExpressionConverter {
// But these two conversions already exist and well tested. So, we are
going with this approach.
SparkFilters.convert(DataSourceStrategy.translateFilter(sparkExpression,
supportNestedPredicatePushdown = true).get)
}
+
+ @throws[AnalysisException]
+ def collectResolvedSparkExpression(session: SparkSession, tableName: String,
where: String): Expression = {
+ var expression:Expression = null
+ // Add a dummy prefix linking to the table to collect the resolved spark
expression from analyzed plan.
+ val prefix = String.format("SELECT 42 from %s where ", tableName)
+ val logicalPlan = session.sessionState.sqlParser.parsePlan(prefix + where)
+ val analyzedLogicalPlan = session.sessionState.executePlan(logicalPlan,
CommandExecutionMode.ALL).analyzed
+ analyzedLogicalPlan.collectFirst {
+ case filter: Filter =>
+ expression = filter.expressions.head
+ }
+ expression
Review comment:
One question here, since we are pulling out the relation node here to
get these filters .. do we still need
```convertToIcebergExpression```?
Since we basically can just call
```
SparkFilters.convert(analyzedLogicalPlan.collectFirst { case filter: Filter
=> expression = filter.expressions.head })
```
?
Also is ok to just use collectFirst? Don't we need all possible Filter
expressions? I may have forgotten how this works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
