kbendick commented on pull request #3780: URL: https://github.com/apache/iceberg/pull/3780#issuecomment-998507583
> This is an update to #3293 that implements the `FileAppender` contract more closely to avoid test failures. > > This renames `writer` to `ensureWriterInitialized` and updates previous calls to `writer()` that would initialize the writer -- even if the appender was closed -- with null checks. `ensureWriterInitialized` is called when flushing a row group from the column write store to the file. I like this idea. My analysis on the former approach was the same as yours. There are also some fields that are built based off of the writer and associated factories that need to also be adjusted for lazy initialization (I believe). I'd be happy to also put a pair of eyes on this PR as well as it's an important part of the code. A large thank you to @NeQuissimus for the GCP-HDFS library concern. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
