rdblue commented on a change in pull request #3908:
URL: https://github.com/apache/iceberg/pull/3908#discussion_r786303956
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -87,6 +89,8 @@ public void initialize(String inputName, Map<String, String>
properties) {
this.conf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname,
properties.get(CatalogProperties.WAREHOUSE_LOCATION));
}
+ this.filterIcebergTable =
Boolean.parseBoolean(properties.get(CatalogProperties.FILTER_ICEBERG_TABLE));
Review comment:
It isn't clear from the property name what this is doing. Looks like
you're trying to avoid calling `getTableObjectsByName` because that is slow.
But it is needed to check whether a table is Iceberg or not.
I think it is a good idea to be able to list all tables and not just Iceberg
tables, so instead of a "filter" setting that is unclear about what is filtered
out, let's change it to be a setting to return all tables vs just Iceberg
tables. How about `list-all=true` to list all tables and not just Iceberg
tables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
