samredai commented on a change in pull request #4021:
URL: https://github.com/apache/iceberg/pull/4021#discussion_r796955779
##########
File path: python/tests/io/test_base.py
##########
@@ -88,8 +95,15 @@ def exists(self):
def to_input_file(self):
return LocalInputFile(location=self.location)
- def create(self, overwrite: bool = False) -> None:
- return open(self.parsed_location.path, "wb" if overwrite else "xb")
+ def create(self, overwrite: bool = False) -> OutputStream:
+ output_file = open(self.parsed_location.path, "wb" if overwrite else
"xb")
+ if not isinstance(output_file, OutputStream):
+ raise RuntimeError(
+ """
Review comment:
We've been planning on increasing the auto formatter's line length
setting for a while so I took this opportunity to open PR #4025 length for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
