szehon-ho commented on pull request #4018: URL: https://github.com/apache/iceberg/pull/4018#issuecomment-1027466195
Hi @SinghAsDev , I see now, if I understand this is making gc.enabled synonymous with another table property 'external', but only in case of HiveCatalog. It sounds reasonable to me, but is it too specific for Spark -> HiveCatalog setup? As there's several clients (Spark, Hive, Flink, Trino) and several catalogs (Hive, Glue, JDBC, REST?), I wonder if we have to make 'external' a recognized Iceberg table property across all catalogs to make it standard. Just thinking aloud, would an easier fix for Spark's Catalog to just do the mapping from 'external' => 'gc.enabled', like Hive is doing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
