rdblue commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r799087029
########## File path: core/src/test/java/org/apache/iceberg/rest/requests/TestCreateNamespaceRequest.java ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import java.util.Map; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.util.JsonUtil; +import org.assertj.core.api.Assertions; +import org.junit.Test; + +public class TestCreateNamespaceRequest { + + private static final ObjectMapper MAPPER = JsonUtil.withRESTComponents(); + + // Non-empty + private static final String JSON_REQUEST_STRING = + "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":{\"owner\":\"Hank\"}}"; + private static final Namespace NAMESPACE = Namespace.of("accounting", "tax"); + private static final Map<String, String> PROPERTIES = ImmutableMap.of("owner", "Hank"); + + // Empty - The response requires a non-empty namespace + private static final String JSON_REQUEST_NO_PROPERTIES = + "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":{}}"; + + @Test + public void testDeserialize() throws JsonProcessingException { + CreateNamespaceRequest expected = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .withProperties(PROPERTIES) + .build(); + + CreateNamespaceRequest actual = MAPPER.readValue(JSON_REQUEST_STRING, CreateNamespaceRequest.class); + + assertSame(expected, actual); + } + + @Test + public void testDeserializeNoProperties() throws JsonProcessingException { + CreateNamespaceRequest expected = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .build(); + + CreateNamespaceRequest actual = MAPPER.readValue(JSON_REQUEST_NO_PROPERTIES, CreateNamespaceRequest.class); + + assertSame(expected, actual); + } + + @Test + public void testSerialize() throws JsonProcessingException { + CreateNamespaceRequest req = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .withProperties(PROPERTIES) + .build(); + + Assertions.assertThat(MAPPER.writeValueAsString(req)) + .isEqualTo(JSON_REQUEST_STRING); + } + + @Test + public void testSerializeNoProperties() throws JsonProcessingException { + CreateNamespaceRequest req = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE) + .build(); + + Assertions.assertThat(MAPPER.writeValueAsString(req)) + .isEqualTo(JSON_REQUEST_NO_PROPERTIES); Review comment: This behavior is fine with me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
