Reo-LEI commented on a change in pull request #2898:
URL: https://github.com/apache/iceberg/pull/2898#discussion_r799520352
##########
File path:
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -283,15 +284,27 @@ public Builder uidPrefix(String newPrefix) {
}
}
+ // Find out the equality field id list based on the user-provided
equality field column names.
+ List<Integer> equalityFieldIds = Lists.newArrayList();
Review comment:
Currently, the `equalityFieldIds` value come from the
`equalityFieldColumns`, and the `equalityFieldColumns` setting by user or parse
from primary key of SQL.
Usually, the `equalityFieldColumns` should equal to the `identifierFieldIds`
of schema, and we don't need the default value of `equalityFieldIds`. But when
user remove the setting of `equalityFieldColumns` or remove parimary key from
SQL, and the `identifierFieldIds` is not null. If we use `identifierFieldIds`
as default value of `equalityFieldIds`, I can't imagine what's going to happen,
maybe it's not what the user wants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
