jackye1995 commented on a change in pull request #4102:
URL: https://github.com/apache/iceberg/pull/4102#discussion_r807555105
##########
File path: aws/src/main/java/org/apache/iceberg/aws/glue/DynamoLockManager.java
##########
@@ -60,8 +60,9 @@
import
software.amazon.awssdk.services.dynamodb.model.TransactionConflictException;
/**
- * DynamoDB implementation for the lock manager.
+ * @deprecated will be removed in 0.15.0, please use {@link
org.apache.iceberg.aws.dynamodb.DynamoDbLockManager}
*/
+@Deprecated
class DynamoLockManager extends LockManagers.BaseLockManager {
Review comment:
The class path is already changing, so I thought it's better to make
things consistent, as I said in the description
> Note that the new class is DynamoDbLockManager instead of
DynamoLockManager to follow DynamoDb prefix convention (because the new Dynamo
client in AWS SDK v2 is named DynamoDbClient).
but no strong opinion here. Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
