RussellSpitzer commented on a change in pull request #4126:
URL: https://github.com/apache/iceberg/pull/4126#discussion_r807980736
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/procedures/BaseProcedure.java
##########
@@ -151,4 +168,31 @@ TableCatalog tableCatalog() {
return tableCatalog;
}
}
+
+ /**
+ * Closes the procedure's executor service if a new one was created.
+ */
+ protected void closeService() {
+ if (executorService != null) {
+ executorService.shutdown();
+ try {
+ executorService.awaitTermination(1, TimeUnit.SECONDS);
Review comment:
Sure although honestly if we are waiting in something at this point it
seems like the procedure has a bug in it. This is why I initially had the wait
check, anything running at all here means the procedure hasn't really completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
