openinx commented on a change in pull request #4157:
URL: https://github.com/apache/iceberg/pull/4157#discussion_r809710633
##########
File path: settings.gradle
##########
@@ -87,30 +87,30 @@ if (!flinkVersions.isEmpty()) {
}
if (flinkVersions.contains("1.12")) {
- include ':iceberg-flink:flink-1.12'
- include ':iceberg-flink:flink-runtime-1.12'
- project(':iceberg-flink:flink-1.12').projectDir = file('flink/v1.12/flink')
- project(':iceberg-flink:flink-1.12').name = 'iceberg-flink-1.12'
- project(':iceberg-flink:flink-runtime-1.12').projectDir =
file('flink/v1.12/flink-runtime')
- project(':iceberg-flink:flink-runtime-1.12').name =
'iceberg-flink-runtime-1.12'
+ include ":iceberg-flink:flink-1.12_${scalaVersion}"
+ include ":iceberg-flink:flink-runtime-1.12_${scalaVersion}"
+ project(":iceberg-flink:flink-1.12_${scalaVersion}").projectDir =
file('flink/v1.12/flink')
+ project(":iceberg-flink:flink-1.12_${scalaVersion}").name =
"iceberg-flink-1.12_${scalaVersion}"
+ project(":iceberg-flink:flink-runtime-1.12_${scalaVersion}").projectDir =
file('flink/v1.12/flink-runtime')
+ project(":iceberg-flink:flink-runtime-1.12_${scalaVersion}").name =
"iceberg-flink-runtime-1.12_${scalaVersion}"
}
if (flinkVersions.contains("1.13")) {
- include ':iceberg-flink:flink-1.13'
- include ':iceberg-flink:flink-runtime-1.13'
- project(':iceberg-flink:flink-1.13').projectDir = file('flink/v1.13/flink')
- project(':iceberg-flink:flink-1.13').name = 'iceberg-flink-1.13'
- project(':iceberg-flink:flink-runtime-1.13').projectDir =
file('flink/v1.13/flink-runtime')
- project(':iceberg-flink:flink-runtime-1.13').name =
'iceberg-flink-runtime-1.13'
+ include ":iceberg-flink:flink-1.13_${scalaVersion}"
+ include ":iceberg-flink:flink-runtime-1.13_${scalaVersion}"
+ project(":iceberg-flink:flink-1.13_${scalaVersion}").projectDir =
file('flink/v1.13/flink')
+ project(":iceberg-flink:flink-1.13_${scalaVersion}").name =
"iceberg-flink-1.13_${scalaVersion}"
+ project(":iceberg-flink:flink-runtime-1.13_${scalaVersion}").projectDir =
file('flink/v1.13/flink-runtime')
+ project(":iceberg-flink:flink-runtime-1.13_${scalaVersion}").name =
"iceberg-flink-runtime-1.13_${scalaVersion}"
}
if (flinkVersions.contains("1.14")) {
- include ':iceberg-flink:flink-1.14'
- include ':iceberg-flink:flink-runtime-1.14'
- project(':iceberg-flink:flink-1.14').projectDir = file('flink/v1.14/flink')
- project(':iceberg-flink:flink-1.14').name = 'iceberg-flink-1.14'
- project(':iceberg-flink:flink-runtime-1.14').projectDir =
file('flink/v1.14/flink-runtime')
- project(':iceberg-flink:flink-runtime-1.14').name =
'iceberg-flink-runtime-1.14'
+ include ":iceberg-flink:flink-1.14_${scalaVersion}"
+ include ":iceberg-flink:flink-runtime-1.14_${scalaVersion}"
+ project(":iceberg-flink:flink-1.14_${scalaVersion}").projectDir =
file('flink/v1.14/flink')
+ project(":iceberg-flink:flink-1.14_${scalaVersion}").name =
"iceberg-flink-1.14_${scalaVersion}"
+ project(":iceberg-flink:flink-runtime-1.14_${scalaVersion}").projectDir =
file('flink/v1.14/flink-runtime')
+ project(":iceberg-flink:flink-runtime-1.14_${scalaVersion}").name =
"iceberg-flink-runtime-1.14_${scalaVersion}"
Review comment:
> Is it possible to do that in a way that doesn’t require two build
calls (one for each Scala version)?
As far as I know, the `gradle` command cannot deploy the projects with two
different values for a given system property. I mean I think the two build
calls to build two separate flink scala runtime jar is the thing we need to do.
I see we usually deploy the artifacts to maven repository by executing this
[stage-binaries.sh](https://github.com/apache/iceberg/blob/master/dev/stage-binaries.sh).
I think it's okay to add the two `gradle` build calls into this bash script.
(In general, I think it's a good question)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
