kbendick commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r810268713
########## File path: core/src/test/java/org/apache/iceberg/rest/requests/TestCreateNamespaceRequest.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import com.fasterxml.jackson.core.JsonProcessingException; +import java.util.Map; +import org.apache.iceberg.AssertHelpers; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.rest.RequestResponseTestBase; +import org.junit.Assert; +import org.junit.Test; + +public class TestCreateNamespaceRequest extends RequestResponseTestBase<CreateNamespaceRequest> { + + /* Values used to fill in request fields */ + private static final Namespace NAMESPACE = Namespace.of("accounting", "tax"); + private static final Map<String, String> PROPERTIES = ImmutableMap.of("owner", "Hank"); + private static final Map<String, String> EMPTY_PROPERTIES = ImmutableMap.of(); + + @Test + // Test cases that are JSON that can be created via the Builder + public void testRoundTripSerDe() throws JsonProcessingException { + String fullJson = "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":{\"owner\":\"Hank\"}}"; + CreateNamespaceRequest req = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE).setProperties(PROPERTIES).build(); + assertRoundTripSerializesEquallyFrom(fullJson, req); + + String jsonEmptyProperties = "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":{}}"; + CreateNamespaceRequest reqWithExplicitEmptyProperties = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE).setProperties(EMPTY_PROPERTIES).build(); + assertRoundTripSerializesEquallyFrom(jsonEmptyProperties, reqWithExplicitEmptyProperties); + + CreateNamespaceRequest reqWithImplicitEmptyProperties = CreateNamespaceRequest.builder() + .withNamespace(NAMESPACE).build(); + assertRoundTripSerializesEquallyFrom(jsonEmptyProperties, reqWithImplicitEmptyProperties); + } + + @Test + // Test cases that can't be constructed with our Builder class but that will parse correctly + public void testCanDeserializeWithoutDefaultValues() throws JsonProcessingException { + CreateNamespaceRequest req = CreateNamespaceRequest.builder().withNamespace(NAMESPACE).build(); + String jsonWithNullProperties = "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":null}"; + assertEquals(deserialize(jsonWithNullProperties), req); + + String jsonWithMissingProperties = "{\"namespace\":[\"accounting\",\"tax\"]}"; + assertEquals(deserialize(jsonWithMissingProperties), req); + } + + @Test + public void testDeserializeInvalidRequest() { + String jsonIncorrectTypeForNamespace = "{\"namespace\":\"accounting%00tax\",\"properties\":null}"; + AssertHelpers.assertThrows( + "A JSON request with incorrect types for fields should fail to deserialize and validate", + JsonProcessingException.class, + "Cannot parse string array from non-array value", + () -> deserialize(jsonIncorrectTypeForNamespace).validate() + ); + + String jsonIncorrectTypeForProperties = "{\"namespace\":[\"accounting\",\"tax\"],\"properties\":[]}"; + AssertHelpers.assertThrows( + "A JSON request with incorrect types for fields should fail to parse and validate", + JsonProcessingException.class, + () -> deserialize(jsonIncorrectTypeForProperties).validate() + ); + + String jsonMisspelledKeys = "{\"namepsace\":[\"accounting\",\"tax\"],\"propertiezzzz\":{\"owner\":\"Hank\"}}"; + AssertHelpers.assertThrows( + "A JSON request with the keys spelled incorrectly should fail to deserialize and validate", + JsonProcessingException.class, + () -> deserialize(jsonMisspelledKeys).validate() Review comment: I've added in error message validation. But I didn't put it in some places where the error message comes form Jackson. I can do so if you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
