kbendick commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r810395491
########## File path: core/src/main/java/org/apache/iceberg/rest/responses/DropNamespaceResponse.java ########## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.responses; + +import java.util.Objects; +import org.apache.iceberg.exceptions.ValidationException; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * Represents a REST response to drop a namespace. + * <p> + * The server may choose to return an error if the namespace is not empty. + */ +public class DropNamespaceResponse { + + // For Jackson to properly fail when deserializing, this needs to be boxed. + // Otherwise, the boolean is parsed according to "loose" javascript JSON rules. + private Boolean dropped; + + public DropNamespaceResponse() { + // Required for Jackson deserialization + } + + private DropNamespaceResponse(Boolean dropped) { Review comment: It's boxed so that Jackson will return `null` for cases that don't parse (or its missing), so we can validate on that. Whereas a primitive would potentially default to `false`. But since things have changed, let me see if I can make this a primitive. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
