rdblue commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r810546811
########## File path: core/src/main/java/org/apache/iceberg/rest/responses/DropNamespaceResponse.java ########## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.responses; + +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; + +/** + * Represents a REST response to drop a namespace. + * <p> + * The server may choose to return an error if the namespace is not empty. + */ +public class DropNamespaceResponse { + + // For Jackson to properly fail when deserializing, this needs to be boxed. + // Otherwise, the boolean is parsed according to "loose" javascript JSON rules. + private Boolean dropped; + + public DropNamespaceResponse() { + // Required for Jackson deserialization + } + + private DropNamespaceResponse(boolean dropped) { + this.dropped = dropped; + validate(); + } + + DropNamespaceResponse validate() { + Preconditions.checkArgument(dropped != null, + "Cannot instantiate a response to dropping a namespace with missing field: dropped"); Review comment: Cannot instantiate? This is already instantiated. I think this should be `"Invalid response, missing field: dropped"` This is the kind of context that I think gets in the way. My guess is that this was an error message that hasn't been updated after some refactoring. It's easy to have that happen, which is why it's a good idea to omit context that isn't needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
