kbendick commented on a change in pull request #4037: URL: https://github.com/apache/iceberg/pull/4037#discussion_r811412445
########## File path: core/src/main/java/org/apache/iceberg/rest/requests/UpdateNamespacePropertiesRequest.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iceberg.rest.requests; + +import java.util.Collection; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import org.apache.iceberg.relocated.com.google.common.base.MoreObjects; +import org.apache.iceberg.relocated.com.google.common.base.Preconditions; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap; +import org.apache.iceberg.relocated.com.google.common.collect.ImmutableSet; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; + +/** + * A REST request to set and/or remove properties on a namespace. + */ +public class UpdateNamespacePropertiesRequest { + + private List<String> removals; + private Map<String, String> updates; + + public UpdateNamespacePropertiesRequest() { + // Required for Jackson deserialization. + } + + private UpdateNamespacePropertiesRequest(List<String> removals, Map<String, String> updates) { + this.removals = removals; + this.updates = updates; + validate(); + } + + UpdateNamespacePropertiesRequest validate() { + Preconditions.checkArgument(removals != null || updates != null, + "Invalid value for update namespace properties request: at least one of updates and removals must be non-null"); Review comment: Yeah I agree. And the original motivation was to disallow requests that I thought didn't make sense, but if the server is updating properties itself on every update properties call, such as a `last_updated_at` timestamp, then an empty request would be valid. We shouldn't disallow that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
