singhpk234 commented on a change in pull request #4215:
URL: https://github.com/apache/iceberg/pull/4215#discussion_r813543033
##########
File path: docs/common/format/spec.md
##########
@@ -34,15 +34,15 @@ The format version number is incremented when new features
are added that will b
Version 1 of the Iceberg spec defines how to manage large analytic tables
using immutable file formats: Parquet, Avro, and ORC.
-All version 1 data and metadata files are valid after upgrading a table to
version 2. [Appendix E](#version-2) documents how to default version 2 fields
when reading version 1 metadata.
+All version 1 data and metadata files are valid after upgrading a table to
version 2. [Appendix E](spec/#version-2) documents how to default version 2
fields when reading version 1 metadata.
#### Version 2: Row-level Deletes
Version 2 of the Iceberg spec adds row-level updates and deletes for analytic
tables with immutable files.
The primary change in version 2 adds delete files to encode that rows that are
deleted in existing data files. This version can be used to delete or replace
individual rows in immutable data files without rewriting the files.
-In addition to row-level deletes, version 2 makes some requirements stricter
for writers. The full set of changes are listed in [Appendix E](#version-2).
+In addition to row-level deletes, version 2 makes some requirements stricter
for writers. The full set of changes are listed in [Appendix
E](spec/#version-2).
Review comment:
similar changes will be required in ### Row level Deletes sections :
as per this PR : https://github.com/apache/iceberg-docs/pull/47/files
---
should we just cherry-pick this pr's commit in your branch.
Appologies I somehow missed backporting my PR, I am happy to even volunteer
to backport this in a separate PR in iceberg repo.
##########
File path: docs/common/format/spec.md
##########
@@ -837,7 +837,7 @@ Note that the string map case is for maps where the key
type is a string. Using
Values should be stored in Parquet using the types and logical type
annotations in the table below. Column IDs are required.
-Lists must use the [3-level
representation](https://github.com/apache/parquet-format/blob/master/LogicalTypes#lists).
+Lists must use the [3-level
representation](https://github.com/apache/parquet-format/blob/master/LogicalTypes,md#lists).
Review comment:
[minor] The url should be :
```suggestion
Lists must use the [3-level
representation](https://github.com/apache/parquet-format/blob/master/LogicalTypes.md#lists).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
