hililiwei commented on a change in pull request #3784:
URL: https://github.com/apache/iceberg/pull/3784#discussion_r832984029
##########
File path:
flink/v1.13/flink/src/test/java/org/apache/iceberg/flink/actions/TestRewriteDataFilesAction.java
##########
@@ -331,7 +332,7 @@ public void testRewriteAvoidRepeateCompress() throws
IOException {
try (FileAppender<Record> fileAppender =
genericAppenderFactory.newAppender(Files.localOutput(file), format)) {
long filesize = 20000;
for (; fileAppender.length() < filesize; count++) {
- Record record = SimpleDataUtil.createRecord(count, "iceberg");
Review comment:
When I use the following formula:
`(long) (dataLength + (estimateMemory + (long) batch.size * avgRowByteSize)
* Rate);`
If we use the "iceberg" as a test data, it is possible to pass this use case
when the rate is less than or equal to 0.017. This value seems to be small.
A large number of repeated data, resulting in only 404 bytes of the
generated files, and uuid-generated files about 22,2432 bytes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
