dungdm93 commented on a change in pull request #3784:
URL: https://github.com/apache/iceberg/pull/3784#discussion_r834417381
##########
File path: core/src/main/java/org/apache/iceberg/io/FanoutDataWriter.java
##########
@@ -52,13 +51,7 @@ public FanoutDataWriter(FileWriterFactory<T> writerFactory,
OutputFileFactory fi
@Override
protected FileWriter<T, DataWriteResult> newWriter(PartitionSpec spec,
StructLike partition) {
- // TODO: support ORC rolling writers
- if (fileFormat == FileFormat.ORC) {
Review comment:
When `ORC` support rolling writers, `fileFormat` is using in no where.
Should we deprecated/remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
